New way to populate locals() for filter #247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
reviewed
Jun 17, 2024
| @@ -202,9 +202,11 @@ def evaluate(expression, data, _node=None): | |||
| Expects data dictionary which will be used to populate local | |||
| namespace. Used to provide flexible conditions for filtering. | |||
| """ | |||
| locals().update(data) | |||
| # Since python3.13 and https://peps.python.org/pep-0667/ | |||
| _locals = copy.deepcopy(locals()) | |||
There was a problem hiding this comment.
I don’t believe deepcopy() is needed. locals() should regurn an independent snapshot of local namespace, i.e. we would be making (and updating) a copy of dictionary no other part of code can ever see. Seems superfluous.
There was a problem hiding this comment.
In other words, I agree we need to store locals() somewhere if we need to both update it and pass it to a function call, ut IIUIC, we don’t need to work with a copy of said dictionary.
|
Drop in favor of #248 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details in https://docs.python.org/3.13/whatsnew/3.13.html#whatsnew313-locals-semantics
Fix: #246