Implement --env for testcloud provisioner #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert and fixes 1 when merging cd3fce4 into 83f699d - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 1 alert and fixes 1 when merging e792f45 into 83f699d - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request fixes 1 alert when merging eee8835 into 83f699d - view on LGTM.com fixed alerts:
|
Closed
thrix
force-pushed
the
rfe-env-testcloud
branch
from
eee8835
to
db779a4
Compare
|
This pull request introduces 1 alert and fixes 1 when merging db779a4 into 50d8a5a - view on LGTM.com new alerts:
fixed alerts:
|
thrix
force-pushed
the
rfe-env-testcloud
branch
from
db779a4
to
99836fd
Compare
|
This pull request introduces 1 alert and fixes 1 when merging 99836fd into a543b3b - view on LGTM.com new alerts:
fixed alerts:
|
Along the way also: * improve a bit how image is detected, so the user can just pass a path, and tmt adds testcloud required prefix 'file://' by itself. * make sure finish runs only if there is an instance provisioned Signed-off-by: Miroslav Vadkerti <mvadkert@redhat.com>
psss
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along the way also:
improve a bit how image is detected, so the user can just pass a path, and tmt adds testcloud required prefix 'file://' by itself.
make sure finish runs only if there is an instance provisioned
Note: also bundles #132, pls review only the commit with the same name as the description of the PR