Narrow type of hardware constraint variants #2290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
added
area | hardware
happz
force-pushed
the
hardware-variants-are-constraints
branch
from
41d403f
to
d120658
Compare
|
/packit retest-failed |
psss
approved these changes
Sep 20, 2023
psss
force-pushed
the
hardware-variants-are-constraints
branch
3 times, most recently
from
bdc7859
to
7bb07ac
Compare
It was implemented as a list of `BaseConstraint` classes, but as no compound constraint can be member of the list, we can narrow the type and allow pure `Constraint` lists.
psss
force-pushed
the
hardware-variants-are-constraints
branch
from
7bb07ac
to
c0649ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was implemented as a list of
BaseConstraintclasses, but as no copound constraint can be member of the list, we can narrow the type and allow pureConstraintlists.