-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export support --bugzilla to link case #808
Conversation
deaae91
to
d129af2
Compare
This pull request introduces 1 alert when merging d129af2 into 377dd6b - view on LGTM.com new alerts:
|
d129af2
to
5ea421c
Compare
The 'export' part should be ready. Asking for your feedback. |
This pull request introduces 3 alerts when merging 5ea421c into 377dd6b - view on LGTM.com new alerts:
|
5ea421c
to
01809c9
Compare
/packit test |
@hegerj, perhaps something you would like to have a look at? |
01809c9
to
aff7103
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing this! Looks good and works as expected. Added a short mention about the new feature to the documentation plus a couple of minor adjustments in aff7103. Please, have a look if everything's ok.
@psss LGTM, thanks for adjustments. |
Good, thanks. The integration test seems to be failing. Could you please have a look? |
Tests are failing in a weird way, seems we need a |
What I found so far:
test_create fails with unable to create a test case error which is raised as returned dict (from require's tcms call) doesn't contain case_id (which would be if case was created). But I don't see how this could happen. test_create require playbook was not touched at all. |
there is correlation between nitrate cache and order of test case execution inside pytest.
|
I've pushed commit which splits tests/integration execution into two virtual cases. Not ideal but hopefully it will work |
fedora-35 issue is caused by sphinx not yet supporting python 3.10 (sphinx-doc/sphinx#9562) |
Yep, it is possible solution. better would be to split all testcases, instead of random splittng, because then when you execute some testcases by pytest alone it will fail as well, because now it depends on order. Or maybe better solution could be to clean |
Personally I'd prefer to get this PR merged and do the testsuite improvements as a separate effort. |
Yes, it's possible to call |
For bugzilla links with verifies relation in the test: Add Bug to the Nitrate case Optionally link Bug to the Nitrate case Add python-bugzilla dependency for tmt-tests-convert Claim Python 3.9 compatibility in Pypi Split tests/integration into two Resolves #689
Add a short mention about the new option to the documentation. Plus a couple of minor style and wording adjustments.
8406453
to
41e7855
Compare
Rebased and squashed, let's see if tests are green. |
Known failure on Fedora 34, otherwise green. |
Todo:
All done, ready for final review