-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32 is no SoftwareSerial Compatible Platform #59
Comments
@teemuatlut I agree with @p0wl, please consider removing ESP32 from the list of SW serial capable platforms. Alternatively, include a note about a compatible SoftwareSerial.h implementation for the ESP32 that can work with this TMCStepper library. Or maybe a dummy SoftwareSerial.h like what was done for STM32F1 in Marlin. Or just keep this issue open so that anyone with problems will come across it. 😅 |
Created a PR, this is the only required change: #62 |
Awesome, thanks for merging! |
Well, ESP is not included in SW_CAPABLE_PLATFORM in my case but for some reason i can't set current for 3 stepper motors with 3 individual TMC2209. I can make them move fine with this library but i want to set current for each Stepper motor. Have any idea about what's wrong ? Or what do i need to give so anyone can help me ? Please let me know. |
Hi!
first of all, thanks for your great library. We are using it to configure 3xTMC2209 using UART from a ESP32 and it's working quite nice.
The problem is that we have to monkey patch TMCStepper.h because it tries to include SoftwareSerial.h. I saw your latest commit that would probably fix it, but I'm questioning why you included ESP32 as a
SW_CAPABLE_PLATFORM
in the first place (in 0d11a14). I read all the issues in the repository about it, but I did not find anyone who said that it was needed. It was expressed by @bdring that it caueses problems for her/him as well: #35 (comment)Also, there are other libraries who are explicitly NOT using SoftwareSerial on an esp32: https://github.com/brianrho/GT5X/blob/54fe601441d1d962da2fc8e5f081a0dd5acebf37/examples/count_templates/count_templates.ino#L1-L5
I would suggest removing it from the list of
SW_CAPABLE_PLATFORM
s. What do you think?The text was updated successfully, but these errors were encountered: