Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP-IDF Compatibility #194

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

holgerpieta
Copy link

Generally I prefer the original ESP-IDF instead of the Arduino framework, because it seems to me less magical and more predictable.
So I tried to make this library compile in ESP-IDF without Arduino. Took much less work than I feared, which I guess shows again that this library is very well made. Thanks to everybody involved.

What I did not implement in ESP-IDF is the SPI interface, because I do not have any experience in that field and at first glance I wasn't able to match the Arduino SPI interface and the ESP-IDF API. Maybe someone with more experience can have a look at that.
But then I'm not actually sure the hardware SPI is actually required, because the SW solution exists.
To make sure nobody uses it accidentally (and to make it compile) I conditionally removed the affected constructors when ESP-IDF platform is configured.

I was able to test it on my ESP32 board with a TCM2208 stepper, but I neither have Arduino in place to try it nor any other stepper driver. So I would probably a good idea if someone with Arduino and other stepper drivers would test it before merging it upstream.

@teemuatlut
Copy link
Owner

Hey thanks for the contribution. I'll make sure to port this to the v1 release branch as it has a much better and configurable HAL architecture.
I'm sure I'll also be able to add the SPI interface but I don't have experience with the IDF API yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants