Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update to work with latest version of Paperclip (3.0.2) #13

Merged
merged 3 commits into from Aug 8, 2012

Conversation

Projects
None yet
Contributor

dce commented Apr 3, 2012

See: y8#11

+1 for this one.
Thanks @dce.

Just encountered the same issue today. Please merge this.

Thanks @dce.

Collaborator

y8 commented Apr 25, 2012

Can you please cover this with a small test case, just to be sure that this issue will not surface again?

Thank you!

Contributor

dce commented Apr 26, 2012

I'll give it a shot. I was getting different, unrelated failures when upgrading then running the suite, but I'll give it some more time.

+1
fixed it for me. please merge it into master of everybody can use it.

Contributor

dce commented Apr 27, 2012

I keep getting this after upgrading to the latest paperclip and then running specs:

/Users/dce/.rvm/gems/ruby-1.9.3-p0@paperclip-meta/gems/paperclip-3.0.2/lib/paperclip/validators/attachment_content_type_validator.rb:3:in `<module:Validators>': uninitialized constant Paperclip::Validators::ActiveModel (NameError)

(full trace: https://gist.github.com/2509759) Anyone have any suggestions?

sikachu commented Apr 27, 2012

What version of Rails are you testing against with? Paperclip now requires Rails >= 3.0.0 (which has ActiveModel.)

Contributor

dce commented Apr 27, 2012

Here's gem list and Gemfile.lock: https://gist.github.com/2510114

sikachu commented Apr 27, 2012

Oh, it seems like I should require active_model on the top of the validator.rb. Let me fix that.

Also, in the test runner, you should not include the paperclip/railtie anymore. You should include Paperclip::Glue into Active Record manually, as we don't have Rails application here. I'm going to send a pull request for that.

Contributor

dce commented Apr 30, 2012

With these updates from @sikachu, the specs fail without my initial patch, and pass with it. I don't think any new specs are required.

hemang commented May 6, 2012

Seems like dce has resolved specs. y8, can you please merge his commit in to master?

ingemar commented May 9, 2012

+1

+1

Thanks, @dce!

gjvis commented Jul 2, 2012

+1
(and thanks @dce!)

toxaq commented Jul 3, 2012

+1

hilem commented Jul 20, 2012

+1

👍

benben commented Jul 26, 2012

+1

y8 added a commit that referenced this pull request Aug 8, 2012

Merge pull request #13 from dce/master
Update to work with latest version of Paperclip (3.0.2)

@y8 y8 merged commit 648f732 into teeparham:master Aug 8, 2012

Collaborator

y8 commented Aug 8, 2012

Oh, thank you @dce! Sorry for this 4 mo delay :(

Merged & v.0.4.3 released.

Contributor

dce commented Aug 8, 2012

Thanks, @y8!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment