Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Subscribe and Publish operations of the same Channel in different classes #91

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

neoaisac
Copy link

If a project tries to define Publish and Subscribe operations in different classes, with the nature of the Channels object as a form of Dictionary<,> the document generator will find a conflicting key in the dictionary when performing the second Add operation, making it impossible to do this.

With this change, a new AddOrApped operation enables a Publish/Subscribe operation to be added to an existing Channel key if the existing one didn't have one defined, while still failing if multiple Publish or Subscribe operations are found for the same Channel.

@m-wild m-wild merged commit f3b8aa4 into asyncapi:master Mar 10, 2021
@m-wild
Copy link
Collaborator

m-wild commented Mar 10, 2021

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants