Manwithhonor sqldb #220
Open
Manwithhonor sqldb #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's a test for git_how_to task
arhangeldim
reviewed
Jan 11, 2018
| String dataBaseName = null; | ||
| int counter=0; | ||
| for ( counter = 0; counter < 3; counter++){ | ||
| dataBaseName = "tdb-"+Integer.toString(counter+1)+".trail5.net:"; |
| append("user=track_student&"). //login | ||
| append("password=7EsH.H6x"); //password | ||
| listOfConnections.put( counter, DriverManager.getConnection(url.toString())); | ||
| } catch ( SQLException e ) { |
There was a problem hiding this comment.
Можно типы исключений отловить через ИЛИ
catch ( SQLException | IllegalAccessException e) {...}
| private Connection findShardInDataBase(String userName) throws IllegalArgumentException{ | ||
| char firstLetterOfUsername = userName.charAt(0); | ||
| try { | ||
| if ( ( ('a' <= firstLetterOfUsername) && (firstLetterOfUsername <= 'j') ) || ( ('A' <= firstLetterOfUsername) && (firstLetterOfUsername <= 'J') ) ){ |
There was a problem hiding this comment.
проще сделать заранее Character::toLowerCase()
| } | ||
| }); | ||
| int res=0; | ||
| if (limit < listOfMessage.size()){ |
There was a problem hiding this comment.
res = Math.min(limit, listOfMessages.size())
| } else { | ||
| res= listOfMessage.size(); | ||
| } | ||
| return listOfMessage.subList(0, res); |
There was a problem hiding this comment.
return происходит из первой итерации цикла?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have completed conversationSevice class.
Implementation into client and server class i will add later