Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not get rid of an excepiton in BasicCryptor.decrypt() #829

Closed
wants to merge 1 commit into from
Closed

Do not get rid of an excepiton in BasicCryptor.decrypt() #829

wants to merge 1 commit into from

Conversation

hokuda
Copy link

@hokuda hokuda commented Nov 11, 2016

No description provided.

@shawkins
Copy link
Contributor

I believe the original intent of not rethrowing the exception was to not reveal the entire stacktrace in case there were version dependent exploits. As you can see in the source all of the exceptions that a client may trigger on the server side do not rethrow the original exception. However since this class is used in both the client and the server we could make the client usage rethrow all exceptions. Is there a reason this change is needed - in general this needs linked to a JIRA issue.

@hokuda
Copy link
Author

hokuda commented Nov 11, 2016

From developer perspective, a verbose stacktrace might be unnecessary. But from support perspective, it is sometimes only a clue to get close to a root cause of a cutomer's issue. I will file a JIRA next week, since it is not functioning now.

@shawkins
Copy link
Contributor

Closing this to work toward a resolution on the JIRA

@shawkins shawkins closed this Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants