Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEIID-4718 added feature to enable HotRod client to use SSL #879

Merged
merged 3 commits into from Jan 25, 2017
Merged

TEIID-4718 added feature to enable HotRod client to use SSL #879

merged 3 commits into from Jan 25, 2017

Conversation

vhalbert
Copy link
Contributor

No description provided.

@shawkins
Copy link
Contributor

I don't see the sni host name being used. Also the password fields should use the $masked extension and may need to be doc'd as using an encrypted value.

This may also be a doc concern, but are there any considerations about the file names - will the classpath, local filesystem, something relative to eap, etc. be used.

@vhalbert
Copy link
Contributor Author

As for SNI, it appears that this feature was added for JDG 7.1 and those jar's are not available at the moment. So the properties are there, just not used yet.

As to location, the initial code will take what's given, meaning a full path or relative path (assuming JDG will find it) can be specified. If you saying that maybe Teiid should offer options for building the String file name that's passed, then sure. I'll log an enhancement.

As for the $masked extension, I'll change that.

@shawkins
Copy link
Contributor

One more small thing, can the direct sys outs be removed from the tests? A logging flag or just java logging could be used instead.

@shawkins shawkins merged commit 17b2342 into teiid:master Jan 25, 2017
@shawkins
Copy link
Contributor

Thanks Van

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants