TEIID-4883 Excel Translator Filter Empty Column Cells #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance the excel translator to filter column cells that are empty. This is only enabled when using a header row and when the importer.allowEmptyHeaderRow is true.
rareddy
reviewed
May 2, 2017
| @@ -57,12 +57,16 @@ | |||
| @ExtensionMetadataProperty(applicable=Column.class, datatype=Integer.class, display="Cell Number", description="Cell number, where the column information is defined. If column name is ROW_ID, define it as -1", required=true) | |||
| public static final String CELL_NUMBER = MetadataFactory.EXCEL_URI+"CELL_NUMBER"; //$NON-NLS-1$ | |||
|
|
|||
| @ExtensionMetadataProperty(applicable=Column.class, datatype=Boolean.class, display="Allow Empty Column Name", description="Allow the column information to contain empty cells.") | |||
There was a problem hiding this comment.
This is not required, this is only needed if you are adding additional metadata proeprties
| @@ -156,6 +160,22 @@ private void addTable(MetadataFactory mf, Sheet sheet, String xlsName, String or | |||
| Row dataRow = null; | |||
| int lastCellNumber = headerRow.getLastCellNum(); | |||
|
|
|||
| // only accept cells that have a value for the name when using a header row | |||
There was a problem hiding this comment.
So this is effectively truncating the table definition until the first non empty row. Is that the intention?
There was a problem hiding this comment.
correct, will only use columns where the header row has non-empty string values. The first empty string cell in the header row marks the end of the table.
|
btw, also add tests please. |
Added new import property "importer.ignoreEmptyHeaderCells" to skip columns in the header that have a empty column name when a header row is specified. Also changed the default behavior to stop adding columns when the first empty header row cell is detected.
|
Thank you @dvilaverde |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the excel translator to filter column cells that are
empty. This is only enabled when using a header row and when
the importer.allowEmptyHeaderRow is true.
See https://issues.jboss.org/browse/TEIID-4883