feat(rce): implement latest version #76
Conversation
Codecov ReportBase: 69.14% // Head: 69.35% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #76 +/- ##
==========================================
+ Coverage 69.14% 69.35% +0.20%
==========================================
Files 12 12
Lines 752 757 +5
Branches 54 55 +1
==========================================
+ Hits 520 525 +5
Misses 201 201
Partials 31 31
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| const runtime = new Runtime( | ||
| configObject.language, | ||
| configObject.version, | ||
| false, | ||
| configObject.extension, | ||
| configObject.compiled, | ||
| configObject.build_command, |
There was a problem hiding this comment.
ini keknya butuh diubah biar constructornya terima object, biar masing masing parameternya bisa dikasih nama, kalo banyak gini jadi bingung
tapi nanti aja deh, biar aku aja yg bikin PRnya
| @@ -13,7 +14,7 @@ export class Runtime { | |||
| public readonly processLimit: number, | |||
| public readonly allowedEntrypoints: number | |||
| ) { | |||
| if (language === "" || version === "" || extension === "" || runCommand.length === 0 || aliases.length === 0 || typeof environment !== "object" || allowedEntrypoints === 0) { | |||
| if (language === "" || version === "" || latest === undefined || extension === "" || runCommand.length === 0 || aliases.length === 0 || typeof environment !== "object" || allowedEntrypoints === 0) { | |||
There was a problem hiding this comment.
ini juga rasanya butuh zod, tapi ntar aku aja deh yg bikin PRnya
Co-authored-by: Dicha Zelianivan Arkana <dicha.arkana03@gmail.com>
Co-authored-by: Dicha Zelianivan Arkana <dicha.arkana03@gmail.com>
Co-authored-by: Dicha Zelianivan Arkana <dicha.arkana03@gmail.com>
Co-authored-by: Dicha Zelianivan Arkana <dicha.arkana03@gmail.com>
|
This pull request introduces 2 alerts when merging 78b0fed into d6fb474 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed 🚀. For more information, please check out our post on the GitHub blog. |
Closes #75