Added task for Conftest #60
Conversation
Conftest is a tool used to validate configuration files using Open Policy Agent. This commit adds a `Task` spec for using Conftest from Tekton, along with documentation of the parameters and usage.
|
Hi @garethr. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
added
needs-ok-to-test
|
/ok-to-test |
tekton-robot
added
ok-to-test
| steps: | ||
| - name: conftest | ||
| workingdir: /workspace/source | ||
| image: instrumenta/conftest:latest |
There was a problem hiding this comment.
@garethr I think we tend to prefer to have "fixed" version image instead of latest, does that make sense ?
There was a problem hiding this comment.
Makes sense. Making this configurable would be good in that case I presume. Do we have any conventions yet around parameter names doing the same?
There was a problem hiding this comment.
not really 🤔 It really depends on the images… on the go tasks we are using version, buildah uses a stable tags..
There was a problem hiding this comment.
@garethr Actually, let's get this merge as is for now. We need to define more guidelines on the catalog, but I don't want to block this or force you to do something that we may have to change later on. As long as instrumenta/conftest:latest doesn't break a lot 😛.
/lgtm
| steps: | ||
| - name: conftest | ||
| workingdir: /workspace/source | ||
| image: instrumenta/conftest:latest |
There was a problem hiding this comment.
not really 🤔 It really depends on the images… on the go tasks we are using version, buildah uses a stable tags..
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: garethr, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/test pull-tekton-catalog-integration-tests |
Changes
Conftest is a tool used to validate configuration files using Open
Policy Agent. This commit adds a
Taskspec for using Conftest fromTekton, along with documentation of the parameters and usage.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.