-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in-toto attestations (ITE-6) as a formatter. #89
Conversation
|
Hi @kommendorkapten. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I'm working on how to proceed with the CLA with my Employer. |
/ok-to-test |
Is this ready for review now @kommendorkapten , or still a WIP? |
@lukehinds It's ready for review. Just consider that the functionality provided is MVP. There are some fields in the in-toto attestation that we don't have a good way of populating now based from the information seen in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kommendorkapten this looks great!
This is awesome! I'm excited to get this in! |
Hey @kommendorkapten this looks great! Would you mind squashing the commits, and then we can merge? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: priyawadhwa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It's happening! |
14447a9
to
bf95e81
Compare
You might still need to squash this all the way down to one commit to get it to merge |
/lgtm |
359ce54
to
490b28f
Compare
/lgtm |
This PR deprecates #88.
This PR implements the basic support for #65.
The formatter uses type hinting to be able to extract information to prepare the in-toto attestation.