Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in-toto attestations (ITE-6) as a formatter. #89

Merged
merged 1 commit into from
May 25, 2021

Conversation

kommendorkapten
Copy link
Contributor

This PR deprecates #88.

This PR implements the basic support for #65.
The formatter uses type hinting to be able to extract information to prepare the in-toto attestation.

@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 17, 2021
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 17, 2021

CLA Signed

The committers are authorized under a signed CLA.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 17, 2021
@tekton-robot
Copy link

Hi @kommendorkapten. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kommendorkapten
Copy link
Contributor Author

I'm working on how to proceed with the CLA with my Employer.

@dlorenc
Copy link
Contributor

dlorenc commented May 20, 2021

/ok-to-test
Yay!

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 20, 2021
@lukehinds
Copy link

Is this ready for review now @kommendorkapten , or still a WIP?

@kommendorkapten
Copy link
Contributor Author

@lukehinds It's ready for review. Just consider that the functionality provided is MVP. There are some fields in the in-toto attestation that we don't have a good way of populating now based from the information seen in the TaskRun struct. Expect follow up work to improve what fields we can populate (e.g when "Hermekton" is finished, there are a set of attributes in the attestation related to hermeticity in builds we should populate).

Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kommendorkapten this looks great!

pkg/chains/formats/simple/simple.go Outdated Show resolved Hide resolved
pkg/chains/formats/tekton/tekton.go Outdated Show resolved Hide resolved
pkg/config/store.go Outdated Show resolved Hide resolved
pkg/chains/formats/intotoite6/intotoite6.go Show resolved Hide resolved
pkg/chains/formats/intotoite6/intotoite6.go Show resolved Hide resolved
@dlorenc
Copy link
Contributor

dlorenc commented May 22, 2021

This is awesome! I'm excited to get this in!

@priyawadhwa
Copy link
Contributor

Hey @kommendorkapten this looks great! Would you mind squashing the commits, and then we can merge?

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2021
@dlorenc
Copy link
Contributor

dlorenc commented May 24, 2021

It's happening!

@tekton-robot tekton-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 25, 2021
@dlorenc
Copy link
Contributor

dlorenc commented May 25, 2021

You might still need to squash this all the way down to one commit to get it to merge

@dlorenc
Copy link
Contributor

dlorenc commented May 25, 2021

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2021
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label May 25, 2021
@priyawadhwa
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2021
@tekton-robot tekton-robot merged commit 86277cc into tektoncd:main May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants