Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for ResourceRef and PipelineRef for TaskRun and PipelineRun Describe to be nil #429

Closed
danielhelfand opened this issue Oct 31, 2019 · 2 comments · Fixed by #501
Closed

Check for ResourceRef and PipelineRef for TaskRun and PipelineRun Describe to be nil #429

danielhelfand opened this issue Oct 31, 2019 · 2 comments · Fixed by #501
Assignees
@piyush-garg
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API

Comments

@danielhelfand
Copy link
Member

With the following pull requests to pipelines, PipelineRef, TaskResourceBinding, and PipelineResourceBinding will be returned as nil when not present with the next release of pipelines:

tektoncd/pipeline#1495
tektoncd/pipeline#1497

When this is updated for the CLI, this will break tkn tr describe and tkn pr describe as they currently rely on checking for an empty string when these resources are not present.

To address 0.9 updates, a similar pattern can be followed as in #418.
@danielhelfand
Copy link
Member Author

/kind api-change

@tekton-robot tekton-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Oct 31, 2019
@piyush-garg
Copy link
Contributor

/assign

piyush-garg added a commit to piyush-garg/cli that referenced this issue Dec 4, 2019
@piyush-garg
Fixes to support tekton pipeline 0.9.0
46ef220 
This will fix the changes required for pipeline 0.9.0
like removing the deprecatedServiceAccount field and
related implementations and test. Chanes in describe command
to handle the pipelineRef and resourceRef

Fix tektoncd#429
@piyush-garg piyush-garg mentioned this issue Dec 4, 2019
Merged
5 tasks
tekton-robot pushed a commit that referenced this issue Dec 4, 2019
@piyush-garg @tekton-robot
Fixes to support tekton pipeline 0.9.0
26aaa1e 
This will fix the changes required for pipeline 0.9.0
like removing the deprecatedServiceAccount field and
related implementations and test. Chanes in describe command
to handle the pipelineRef and resourceRef

Fix #429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piyush-garg piyush-garg

Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump tektoncd/pipeline to version 0.9.0 piyush-garg/cli
3 participants
@piyush-garg @danielhelfand @tekton-robot