Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial pre-submit script… #14

Merged
merged 1 commit into from
Apr 24, 2019

Conversation

vdemeester
Copy link
Member

Changes

… mostly imported from tektoncd/pipeline.

Signed-off-by: Vincent Demeester vdemeest@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2019
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 24, 2019
@vdemeester vdemeester force-pushed the initial-presumit-script branch 2 times, most recently from 299a2a3 to 20d26da Compare April 24, 2019 12:57
@abayer
Copy link
Contributor

abayer commented Apr 24, 2019

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2019
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2019
… mostly imported from `tektoncd/pipeline`.

This adds dummy tests to have some report before we go real tests.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@vdemeester vdemeester changed the title wip: Initial pre-summit script… Initial pre-summit script… Apr 24, 2019
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2019
@vdemeester
Copy link
Member Author

@abayer @sthaha @chmouel it is now ready 💃

@sthaha
Copy link
Member

sthaha commented Apr 24, 2019

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2019
@chmouel
Copy link
Member

chmouel commented Apr 24, 2019

/lgtm

@tekton-robot tekton-robot merged commit 763aba6 into tektoncd:master Apr 24, 2019
@vdemeester vdemeester deleted the initial-presumit-script branch April 24, 2019 13:20
@vdemeester vdemeester changed the title Initial pre-summit script… Initial pre-submit script… Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants