-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vcs links to be static #2304
Closed
chmouel
wants to merge
1
commit into
tektoncd:main
from
chmouel:issue-2303-pre-commit-on-cli-repo-is-broken
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ | |
|
||
- You need to have your own Kubernetes cluster (e.g. `minikube`, `gcp`, or other means) with Tekton installed. | ||
|
||
- You need to have [these tools](https://github.com/tektoncd/cli/blob/main/tekton/release.sh#L13y) installed locally. | ||
- You need to have [these tools](https://github.com/tektoncd/cli/blob/31b05eeba893c75a215f3acbe3986e87f4ae94f5/tekton/release.sh#L13y) installed locally. | ||
|
||
- You will need to have a [GPG key set up](https://help.github.com/en/github/authenticating-to-github/managing-commit-signature-verification) with your git account to push the release branch. | ||
|
||
|
@@ -26,7 +26,7 @@ The steps below are meant to be followed in order. Some steps can be done in a d | |
- Start reading this [README](tekton/README.md), and you can start a new release | ||
with the [release.sh](tekton/release.sh) script. | ||
|
||
- When the release is done in https://github.com/tektoncd/cli/releases, edit the | ||
- When the release is done in <https://github.com/tektoncd/cli/releases>, edit the | ||
release and change it from pre-release to released. Make sure to do this before | ||
the next step for the rpm package. | ||
|
||
|
@@ -55,7 +55,7 @@ dnf upgrade tektoncd-cli | |
|
||
- Make an update on [homebrew-core](https://github.com/Homebrew/homebrew-core/blob/master/Formula/tektoncd-cli.rb) for tektoncd-cli formula. | ||
|
||
* Make sure you get the proper `sha256sum`. You need to download the `Source Code (tar.gz)` from this [link](https://github.com/Homebrew/homebrew-core/blob/master/Formula/tektoncd-cli.rb#L4), but replace the version number with the version number you have released. After downloading, run the command below on the downloaded file (once again you will need to replace the version shown below with the released version): | ||
- Make sure you get the proper `sha256sum`. You need to download the `Source Code (tar.gz)` from this [link](https://github.com/Homebrew/homebrew-core/blob/b031f5eb111abdcee3672ca75a8dabefdd57ced2/Formula/t/tektoncd-cli.rb), but replace the version number with the version number you have released. After downloading, run the command below on the downloaded file (once again you will need to replace the version shown below with the released version): | ||
|
||
```shell script | ||
sha256sum cli-0.7.1.tar.gz | ||
|
@@ -65,16 +65,15 @@ dnf upgrade tektoncd-cli | |
|
||
`72df3075303d2b0393bae9a0f9e9b8441060b8a4db57e613ba8f1bfda03809b5 cli-0.7.1.tar.gz` | ||
|
||
* Raise a PR to update like [this](https://github.com/Homebrew/homebrew-core/pull/46492) to Homebrew Core | ||
- Raise a PR to update like [this](https://github.com/Homebrew/homebrew-core/pull/46492) to Homebrew Core | ||
|
||
- Make a version update to the test-runner and `tkn` image in the [plumbing](https://github.com/tektoncd/plumbing/) repo. The test-runner image is used to run the CI on the pipeline project, which uses `tkn`. For both Dockerfiles listed below, search for `ARG TKN_VERSION` in the Dockerfile for where to update the release version. Update the version arg to match the version of `tkn` released (i.e. `ARG TKN_VERSION=<RELEASED_VERSION>`). | ||
|
||
* [test-runner image](https://github.com/tektoncd/plumbing/blob/main/tekton/images/test-runner/Dockerfile) | ||
- [test-runner image](https://github.com/tektoncd/plumbing/blob/main/tekton/images/test-runner/Dockerfile) | ||
|
||
* [tkn image](https://github.com/tektoncd/plumbing/blob/main/tekton/images/tkn/Dockerfile) | ||
- [tkn image](https://github.com/tektoncd/plumbing/blob/main/tekton/images/tkn/Dockerfile) | ||
|
||
|
||
- Go to https://archlinux.org/packages/community/x86_64/tekton-cli/flag/ and let the packagers know the package is out of date by leaving a message to the release url and your email address so they can update it. | ||
- Go to <https://archlinux.org/packages/community/x86_64/tekton-cli/flag/> and let the packagers know the package is out of date by leaving a message to the release url and your email address so they can update it. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This needs to be |
||
|
||
- Update the version numbers in the main [README.md](README.md) to the version you are releasing by opening a pull request to the main branch of this repository. Do not worry about updating the README for the release branch. | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this also needs update