Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump taskrun describe to v1beta1 #884

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Bump taskrun describe to v1beta1 #884

merged 1 commit into from
Apr 17, 2020

Conversation

piyush-garg
Copy link
Contributor

@piyush-garg piyush-garg commented Apr 9, 2020 •
edited
Loading

This will bump taskrun describe for v1beta1
make the necessary changes in template
and do other refactoring for supporting
both v1alpha1 and v1beta1

Fix e2e

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

Bump taskrun describe to v1beta1

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 9, 2020
@piyush-garg piyush-garg added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/taskrun/description/taskrun_description.go 50.0% 48.9% -1.1

@piyush-garg piyush-garg mentioned this pull request Apr 9, 2020
Merged
3 tasks
@piyush-garg
Copy link
Contributor Author

Blocked on tektoncd/pipeline#2359

@piyush-garg piyush-garg mentioned this pull request Apr 11, 2020
Closed
@vdemeester
Copy link
Member

/retest

2 similar comments
@vdemeester
Copy link
Member

/retest

@vdemeester
Copy link
Member

/retest

@piyush-garg
Bump taskrun describe to v1beta1
492fe59 
This will bump taskrun describe for v1beta1
make the necessary changes in template
and do other refactoring for supporting
both v1alpha1 and v1beta1

Fix e2e
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 17, 2020
@piyush-garg
Copy link
Contributor Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2020
@piyush-garg
Copy link
Contributor Author

This is ready to review and merge as we bumped to tektoncd/pipeline v0.11.2 in vendor using #908

@piyush-garg
Copy link
Contributor Author

/test pull-tekton-cli-go-coverage

vdemeester
vdemeester approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@tekton-robot
Copy link
Contributor

@vdemeester: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/task/task.go 28.6% 69.4% 40.8
pkg/taskrun/description/description.go Do not exist 48.9%
pkg/taskrun/get.go Do not exist 69.0%

@pradeepitm12
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2020
@tekton-robot tekton-robot merged commit 048c65a into tektoncd:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@danielhelfand danielhelfand Awaiting requested review from danielhelfand

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

Assignees

@pradeepitm12 pradeepitm12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@piyush-garg @tekton-robot @vdemeester @pradeepitm12 @googlebot