Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tkn create -f #954

Merged
merged 1 commit into from
May 1, 2020
Merged

Remove tkn create -f #954

merged 1 commit into from
May 1, 2020

Conversation

danielhelfand
Copy link
Member

Closes #816

This pull request removes create -f from tkn pipeline, tkn task, and tkn resource. The recommended creation method for Tekton resources will be to use kubectl, oc, or other Kubernetes tools.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

Release Notes

Remove create -f from tkn pipeline, task, and resource 

@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 30, 2020
@chmouel
Copy link
Member

chmouel commented Apr 30, 2020

perfect thanks

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipelineresource/create.go 11.9% 2.4% -9.5

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipelineresource/create.go 11.9% 2.4% -9.5

@piyush-garg
Copy link
Contributor

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 1, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2020
@tekton-robot tekton-robot merged commit 89a7f6d into tektoncd:master May 1, 2020
chmouel added a commit that referenced this pull request Jun 10, 2020
#945 | [Piyush Garg] Fix release script and yaml | 2020/04/29-13:39
#946 | [Piyush Garg] Update readme for release 0.9.0 | 2020/04/29-14:24
#948 | [Piyush Garg] Fix dockerfile of debbuild | 2020/04/29-17:43
#793 | [Pablo Caderno] Change clusterTask timeout from int to string and remove -t shorthand | 2020/04/30-14:34
#793 | [Pablo Caderno] Removed unnecessary warning message | 2020/04/30-14:34
#952 | [Daniel Helfand] remove default 1h for clustertask --timeout and add tests for invalid timeout | 2020/04/30-16:55
#954 | [Daniel Helfand] remove tkn create -f | 2020/05/01-07:49
#953 | [Vincent Demeester] Bump plumbing to recent master 👼 | 2020/05/01-08:14
#935 | [praveen4g0] Add Task start E2E tests | 2020/05/01-14:06
null | [Anshul Verma] Provides an interactive Prompt to select a Pipeline/PipelineRun/PipelineResources/Task/TaskRun/ClusterTask/ to describe just like what is there in  subcommand. | 2020/05/04-07:41
null | [Pradeep Kumar] fix task start with file | 2020/05/06-14:07
null | [Yulia Gaponenko] Update Readme with s390x build usage | 2020/05/07-09:53
null | [Vibhav Bobade] Update triggerbinding and template `list` error messages | 2020/05/08-15:56
null | [Piyush Garg] Enable yaml lint | 2020/05/10-10:19
null | [Piyush Garg] Refactoring for --all-namespace flag | 2020/05/10-10:33
null | [Piyush Garg] Makefile changes for new skipCheckFlag | 2020/05/10-11:38
null | [vinamra28] Fix to provide an error for tkn completion without argument | 2020/05/13-14:00
null | [charles-edouard.breteche] refacto get pipelines version | 2020/05/14-14:01
null | [savitaashture] Add triggers version info to the version command | 2020/05/15-17:25
null | [Daniel Helfand] switch to sigs.k8s.io/yaml for yaml unmarshal | 2020/05/19-04:38
null | [Alan Greene] Fix 'Edit this page' and 'Create an issue' links on the website | 2020/05/19-04:45
null | [Daniel Helfand] move e2e tests into subcommand packages | 2020/05/19-07:53
null | [Shivam Mukhade] Add Task's timeout and Params to Pipeline Desc | 2020/05/19-10:30
null | [Vibhav Bobade] Add no-headers and all-namespaces flags for pipeline resources | 2020/05/19-15:20
null | [Anshul Verma] Provides `--last` option of the `describe` of PipelineRun/TaskRun to describe the most recent PipelineRun/TaskRun | 2020/05/22-13:08
null | [Daniel Helfand] change taskrun and pipelinerun delete test names | 2020/05/26-11:54
null | [Divyansh42] Fix tkn task delete <name> --trs deletes ClusterTaskrun also | 2020/05/26-12:06
null | [chetan-rns] Display conditions in the pipeline describe command | 2020/05/26-12:17
null | [Pradeep Kumar] Task start interactive mode | 2020/05/26-13:53
null | [vinamra28] Fix to provide error in case of no pr logs | 2020/05/26-14:20
null | [Piyush Garg] Bump tektoncd/pipeline to v0.12.1 | 2020/05/28-06:09
null | [Piyush Garg] Bump tektoncd/triggers to v0.5.0 | 2020/06/02-09:28
null | [Divyansh42] Add `--trs` flag in `tkn ct delete` command | 2020/06/03-14:34
null | [savitaashture] Modified TriggerTemplate describe command for ResourceTemplates | 2020/06/05-09:29
null | [Daniel Helfand] fix --keep with tr and pr delete when using --task or --pipeline flag | 2020/06/10-09:05
null | [Chmouel Boudjnah] Fix Debian package having an incorrect package name | 2020/06/10-10:06
null | [Chmouel Boudjnah] Decrease minor release version to zero | 2020/06/10-10:06
null | [Piyush Garg] Bump tektoncd/pipeline to v0.13.0 | 2020/06/10-14:18

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate tkn create -f
4 participants