Change clusterTask timeout from int to string and remove -t shorthand

[kadern0]

Signed-off-by: kadern0 kaderno@gmail.com

Changes

Changed clusterTask timeout from int64 to string and removed the shorthand -t option.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Run the code checkers with make check
• Regenerate the manpages, docs and go formatting with make generated
• Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

[tekton-robot]

Hi @kadern0. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[danielhelfand]

/hold

Thanks for this pr @kadern0. Unfortunately, this can't be added until version v1.0.0 as documented in #784. We would be happy to accept this, but it will have to wait until after the next release of tkn.

If you are interested in opening a separate pr, we need to add a warning message about this change to users in v0.9.0 that can be added into this upcoming release. The format of the message is detailed in the issue.

[kadern0]

@danielhelfand what do you suggest? Can this wait until version v01.0.0 ?

[danielhelfand]

@danielhelfand what do you suggest? Can this wait until version v01.0.0 ?

I will assign you to the issue if that works for you so that it's clear to others it's being worked on. We can keep this open/give any feedback until v1.0.0 and get this in to that release. Sound good?

[kadern0]

Sounds good to me. Thanks!

[kadern0]

/assign @kadern0

[danielhelfand]

Adding some feedback here for whenever you have a moment. A good reference for if there's any confusion is to look at how this approach was implemented in #779.

[danielhelfand]

/ok-to-test

[danielhelfand]

This looks great! Thank you. Will keep you posted on the status of this, but I would say to expect that this will be introduced some time early next month.

[danielhelfand]

/hold cancel

Thanks for your patience @kadern0. Could you please sign the new CLA the Tekton project has adopted in the last month? Apologies, but I think this should be good to go.

[danielhelfand]

/retest

[kadern0]

Thanks @danielhelfand, I'm happy to sign the new CLA. Could you trigger the bot to verificate so I'm asked for it and I can sign it? (unless there is an easier way to do it)

[danielhelfand]

/test pull-tekton-cli-integration-tests-0_10

[danielhelfand]

Could you try doing a force push? That is unfortunately the only workaround that I have seen.

[linux-foundation-easycla]

• ❌The commit (0b052f19bad5e53b5d662c241de3c6a7d6755cfa) is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.

[kadern0]

@danielhelfand, the force push did the trick (although I had another email set by default and it took me a few pushes to find out).

Now that this is solved, in order to make my code pass the tests, the following warning has to be removed because opt.Timeout is no longer an int:

			if opt.TimeOut != 3600 {
				log.Println("WARNING: The --timeout flag will no longer be specified in seconds in v1.0.0. Learn more here: https://github.com/tektoncd/cli/issues/784")
				log.Println("WARNING: The -t shortand for --timeout will no longer be available in v1.0.0.")
			}

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/clustertask/start.go	89.5%	90.1%	0.6

[danielhelfand]

/lgtm

Thanks @kadern0!

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielhelfand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [danielhelfand]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment