Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update self-reference from master to main 馃 #331

Closed
wants to merge 0 commits into from
Closed

Update self-reference from master to main 馃 #331

wants to merge 0 commits into from

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Feb 3, 2021 •
edited
Loading

This updates any self reference of community repository to target the
main branch instead of the master branch.

/cc @afrittoli @bobcatfish @imjasonh @jerop
/hold

Related to tektoncd/plumbing#681

Signed-off-by: Vincent Demeester vdemeest@redhat.com

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2021
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 3, 2021
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2021
@vdemeester vdemeester added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Feb 3, 2021
Base automatically changed from master to main February 3, 2021 16:34
@vdemeester
Copy link
Member Author

/hold cancel
community default branch is now main, this can be merged 馃槤

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2021
afrittoli
afrittoli reviewed Feb 3, 2021
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

pritidesai
pritidesai reviewed Feb 3, 2021
View reviewed changes
process.md Outdated
@@ -145,7 +145,7 @@ This means that automation will be applied to your pull requests.
The configuration for this automation is in [`tektoncd/plumbing`](https://github.com/tektoncd/plumbing).

_More on the Prow process in general
[is available in the k8s docs](https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md#the-code-review-process)._
[is available in the k8s docs](https://github.com/kubernetes/community/blob/main/contributors/guide/owners.md#the-code-review-process)._
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not needed 馃檭 it still points to master 馃樃

pritidesai
pritidesai reviewed Feb 3, 2021
View reviewed changes
teps/0006-tekton-metrics.md Outdated
@@ -51,7 +51,7 @@ style guide]. In particular, wrap lines to a reasonable length, to make it
easier for reviewers to cite specific portions, and to minimize diff churn on
updates.

[documentation style guide]: https://github.com/kubernetes/community/blob/master/contributors/guide/style-guide.md
[documentation style guide]: https://github.com/kubernetes/community/blob/main/contributors/guide/style-guide.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this replacement is not needed 馃檭

pritidesai
pritidesai reviewed Feb 3, 2021
View reviewed changes
teps/0012-api-spec.md Outdated
@@ -31,7 +31,7 @@ status: implementable

## Motivation

The Tekton Pipelines project provides a common set of cloud-native abstractions to describe container-based, run-to-completion workflows, typically in service of CI/CD scenarios. The Tekton project defines an API, in the [Kubernetes Resource Model](https://github.com/kubernetes/community/blob/master/contributors/design-proposals/architecture/resource-management.md), to describe these building blocks, and a reference implementation of this API that runs on Kubernetes.
The Tekton Pipelines project provides a common set of cloud-native abstractions to describe container-based, run-to-completion workflows, typically in service of CI/CD scenarios. The Tekton project defines an API, in the [Kubernetes Resource Model](https://github.com/kubernetes/community/blob/main/contributors/design-proposals/architecture/resource-management.md), to describe these building blocks, and a reference implementation of this API that runs on Kubernetes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more, stays master 馃樃

pritidesai
pritidesai reviewed Feb 3, 2021
View reviewed changes
teps/0021-results-api.md Outdated
@@ -126,7 +126,7 @@ style guide]. In particular, wrap lines to a reasonable length, to make it
easier for reviewers to cite specific portions, and to minimize diff churn on
updates.

[documentation style guide]: https://github.com/kubernetes/community/blob/master/contributors/guide/style-guide.md
[documentation style guide]: https://github.com/kubernetes/community/blob/main/contributors/guide/style-guide.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, no replacement needed, stays master

pritidesai
pritidesai reviewed Feb 3, 2021
View reviewed changes
teps/0025-hermekton.md Outdated
@@ -86,7 +86,7 @@ type ExecutionMode struct {
```

This currently holds just a single bool, but could be expanded in the future.
See [this rationale](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#primitive-types) in the k8s API style guide for why we introduce a new type.
See [this rationale](https://github.com/kubernetes/community/blob/main/contributors/devel/sig-architecture/api-conventions.md#primitive-types) in the k8s API style guide for why we introduce a new type.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to replace this 馃檭

@pritidesai
Copy link
Member

we have replaced a few kubernetes community references with main, I don't think those changes are needed unless they are being renamed 馃槈

@tekton-robot
Copy link
Contributor

@vdemeester: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2021
@vdemeester vdemeester closed this Mar 4, 2021
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, ImJasonH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 4, 2021
@vdemeester vdemeester deleted the renaming-branch-to-main branch March 4, 2021 13:52
@vdemeester vdemeester mentioned this pull request Mar 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pritidesai pritidesai pritidesai left review comments

@afrittoli afrittoli afrittoli left review comments

@imjasonh imjasonh imjasonh approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@jerop jerop Awaiting requested review from jerop

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vdemeester @pritidesai @tekton-robot @imjasonh @afrittoli