Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to differentiate between Conditions and regular TaskRuns in PipelineRun view #1340

Closed
AlanGreene opened this issue Apr 30, 2020 · 1 comment
Labels
triage/duplicate Indicates an issue is a duplicate of other open issue.

Comments

@AlanGreene
Copy link
Member

AlanGreene commented Apr 30, 2020

Expected behavior

It should be clear from looking at the PipelineRun view when a TaskRun has failed.

Actual behavior

Failed Conditions look like failed TaskRuns which can be a little confusing, especially if the PipelineRun has completed successfully.

Additional Info

We should consider how best to differentiate Conditions from other TaskRuns. In case of success this is probably less important, but for failed Conditions it should be clear they're not a regular failed TaskRun. Perhaps this can be done by changing the status displayed from 'Failed' to 'ConditionFailed' or similar, along with changing from the red highlight to orange / yellow (see Carbon color usage guidelines).

When we resolve #1263 it would be great to indicate the relationship between TaskRuns and Conditions so a user can easily see which TaskRuns were skipped and why.

@AlanGreene AlanGreene added the triage/duplicate Indicates an issue is a duplicate of other open issue. label Jun 24, 2020
@AlanGreene
Copy link
Member Author

Tracked in #1445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/duplicate Indicates an issue is a duplicate of other open issue.
Projects
None yet
Development

No branches or pull requests

1 participant