When a PipelineRun is in progress ensure the TaskTree renders the full set of Tasks

[AlanGreene]

Expected behavior

I expect to see the full set of Tasks reflected in the TaskTree regardless of the status of the PipelineRun.

Actual behavior

When a PipelineRun is in progress we don't currently render all Tasks in the TaskTree, instead only showing those for which we have details of a TaskRun.

Additional Info

Related: #932

We did briefly have this in an early version but removed it due to a number of issues with inconsistencies in the data received, problems with ordering, etc. A lot of changes have been made both to the Dashboard and Pipelines since and I expect most if not all of those issues should now be resolved.

The PipelineRun component would need to receive the Pipeline definition as a prop, and could then extract the required information. We already do this for the PipelineGraph component so that can be used for reference.

We should also revisit how we're retrieving and passing Tasks from the container to ensure we're only passing those required for the Pipeline.

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[tekton-robot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

[tekton-robot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

[tekton-robot]

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[AlanGreene]

/remove-lifecycle rotten
/reopen

[tekton-robot]

@AlanGreene: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[AlanGreene]

1. review current behaviour (with particular focus on ordering) with latest versions of Dashboard + Pipelines
2. update PipelineRun component to accept Pipeline as prop
3. reduce the number of Tasks being loaded to only those relevant for the PipelineRun
4. use Pipeline prop to build the correct Task order (also see Tasks should be sorted in Pipeline spec order not alphabetically #932)

We also need to consider how retries fit into this, while maintaining a consistent / predictable order: #1445
My current suggestion would be to handle display / selection of retries internally within a Task component in the TaskTree, rather than having them displayed as essentially independent TaskRuns in their own right.

[AlanGreene]

This would benefit from #885 as the code that currently sources and combines the required data for the TaskTree component is difficult to understand and modify. There are too many custom representations of the data in use, this needs to be simplified so we can more easily use the definitions to construct the UI, and then fill in the runtime information from the PipelineRun / TaskRun status. The code currently blurs the lines between these two sets of data leading to confusion about the true source of some fields.

[AlanGreene]

/kind design