Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass timeframe to external-logs service #2908

Closed
AverageMarcus opened this issue May 9, 2023 · 1 comment · Fixed by #2909
Closed

Pass timeframe to external-logs service #2908

AverageMarcus opened this issue May 9, 2023 · 1 comment · Fixed by #2909
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@AverageMarcus
Copy link
Contributor

Feature request

When calling to the external-logs proxy it'd be useful to have the approx timeframe that the logs should be found within.

Use case

Currently we use Loki as our long-term log storage and for efficiency reasons we limit the dashboard logs proxy to only look back for ~3 days to ensure the result returns quick enough to be useful. If we had the start / completion time of the expected logs we could craft much more specific queries that would return much quicker and can be from far in the past.

Alternatives

  • Limit the period that logs can be retrieved from (this is what we currently have)

Additional context

@AverageMarcus AverageMarcus added the kind/feature Categorizes issue or PR as related to a new feature. label May 9, 2023
@AlanGreene
Copy link
Member

Thanks Marcus for this great suggestion. I agree that it makes sense to include this in the Dashboard. Thanks for submitting the PR too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants