-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate RBAC used to lookup triggers and pipelines versions #1406
Conversation
a194b2f
to
269a9f6
Compare
/test pull-tekton-dashboard-integration-tests |
/test pull-tekton-dashboard-integration-tests |
2 similar comments
/test pull-tekton-dashboard-integration-tests |
/test pull-tekton-dashboard-integration-tests |
/meow |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not seeing any issues testing this on my OpenShift cluster, resources all popping up in the right namespaces and Triggers/Pipelines is still being detected great
/lgtm
/meow hats
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-roberts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
This PR separates
ClusterRole
s used to look up pipelines and triggers version from the mainClusterRole
.These two new
ClusterRole
s are added to the dashboard service account usingRoleBinding
s and therefore target a single namespace (not the whole cluster)./cc @AlanGreene @a-roberts
Extracted from the giant PR #1371
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.