Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate RBAC used to lookup triggers and pipelines versions #1406

Merged
merged 1 commit into from
May 21, 2020

Conversation

eddycharly
Copy link
Member

Changes

This PR separates ClusterRoles used to look up pipelines and triggers version from the main ClusterRole.

These two new ClusterRoles are added to the dashboard service account using RoleBindings and therefore target a single namespace (not the whole cluster).

/cc @AlanGreene @a-roberts

Extracted from the giant PR #1371

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 20, 2020
@eddycharly eddycharly force-pushed the split-rbac branch 2 times, most recently from a194b2f to 269a9f6 Compare May 20, 2020 14:22
@eddycharly
Copy link
Member Author

/test pull-tekton-dashboard-integration-tests

@bobcatfish
Copy link
Contributor

/test pull-tekton-dashboard-integration-tests

2 similar comments
@eddycharly
Copy link
Member Author

/test pull-tekton-dashboard-integration-tests

@bobcatfish
Copy link
Contributor

/test pull-tekton-dashboard-integration-tests

@eddycharly
Copy link
Member Author

/meow

@tekton-robot
Copy link
Contributor

@eddycharly: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@a-roberts a-roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not seeing any issues testing this on my OpenShift cluster, resources all popping up in the right namespaces and Triggers/Pipelines is still being detected great

/lgtm
/meow hats

@tekton-robot
Copy link
Contributor

@a-roberts: cat image

In response to this:

Not seeing any issues testing this on my OpenShift cluster, resources all popping up in the right namespaces and Triggers/Pipelines is still being detected great

/lgtm
/meow hats

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-roberts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2020
@tekton-robot tekton-robot merged commit a91b799 into tektoncd:master May 21, 2020
@eddycharly eddycharly deleted the split-rbac branch May 21, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants