-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting to enable log timestamps #2147
Add setting to enable log timestamps #2147
Conversation
d807bd0
to
bac12da
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
bac12da
to
df8906e
Compare
fd16f9a
to
7db295b
Compare
@briangleeson rebased to resolve merge conflict |
Add a toggle to the Settings page to allow users to display timestamps on the step container logs. This produces a timestamp prefix on each line in the same way as `kubectl logs <pod> --timestamps` and uses the functionality provided by the Kubernetes API server.
7db295b
to
0ff4589
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this working? Can someone confirm what versions this actually works on? |
This was introduced in Dashboard v0.19.0 and is working as expected in recent releases. Here's an example with it disabled: View the same logs, now with timestamps: You can test it for yourself at https://dashboard.dogfooding.tekton.dev/#/namespaces/tekton-ci/pipelineruns/9887b780-53c4-check-pr-has-kind-label-logs-stop?pipelineTask=create-data&step=write-data If you're having trouble with this feature please open an issue with details or join us on Slack and we'll see what we can do to help. |
Great! Can confirm, it works on |
Changes
Depends on #2146Closes #2145
Add a toggle to the Settings page to allow users to display timestamps
on the step container logs. This produces a timestamp prefix on each
line in the same way as
kubectl logs <pod> --timestamps
and usesthe functionality provided by the Kubernetes API server.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.