Enable React Fast Refresh and Strict Mode for Storybook #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/S
AlanGreene
requested review from
briangleeson
and removed request for
skaegi and
steveodonovan
Enable React Fast Refresh for more efficient hot reloading of changes to React components while doing a better job of maintaining state. Enable Strict Mode to catch potential issues earlier. This is enabled by explicity adding a `React.StrictMode` wrapper in the root decorator instead of in the Storybook config due to an incompatibility with our current combination of addons.
AlanGreene
force-pushed
the
storybook_config
branch
from
c46a447
to
bbf470c
Compare
tekton-robot
added
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Enable React Fast Refresh for more efficient hot reloading of changes
to React components while doing a better job of maintaining state.
Enable Strict Mode to catch potential issues earlier. This is enabled
by explicity adding a
React.StrictModewrapper in the root decoratorinstead of in the Storybook config due to an incompatibility with our
current combination of addons.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.