Remove the update-deps script #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The update-deps script hasn't been used in a long time, since we stopped depending on any knative packages. It's no longer needed as the only remaining steps are `go mod tidy` and `go mod vendor` which are standard commands for working with go modules already covered in the docs and the test scripts. Keep the tools.go file in the hack folder as we still depend on tektoncd/plumbing scripts for tests.
tekton-robot
added
the
size/M
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
|
|
/test tekton-dashboard-unit-tests |
1 similar comment
|
/test tekton-dashboard-unit-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The update-deps script hasn't been used in a long time, since we
stopped depending on any knative packages. It's no longer needed
as the only remaining steps are
go mod tidyandgo mod vendorwhich are standard commands for working with go modules already
covered in the docs and the test scripts.
Keep the tools.go file in the hack folder as we still depend on
tektoncd/plumbing scripts for tests.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
See the contribution guide
for more details.