Add rbac removal for when auth with proxy #2291
Conversation
tekton-robot
added
the
size/S
|
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @mlbiam. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
added
the
needs-ok-to-test
| @@ -199,6 +199,21 @@ By default the Dashboard accesses resources and performs actions in the cluster | |||
|
|
|||
| Typically when configuring impersonation you would have the proxy forward its ServiceAccount token in the `Authorization` header, and details of the user and groups in the `Impersonate-User` and `Impersonate-Group` headers respectively. See the docs of your chosen solution for details. | |||
|
|
|||
| When using a reverse proxy, with impersonation headers or the user's account, you should remove the dashboard's privileges to better maintain a "least privileged" approach. This will make it less likely that the dashboard's `ServiceAccount` will be abused: | |||
There was a problem hiding this comment.
nit:
| When using a reverse proxy, with impersonation headers or the user's account, you should remove the dashboard's privileges to better maintain a "least privileged" approach. This will make it less likely that the dashboard's `ServiceAccount` will be abused: | |
| When using a reverse proxy, with impersonation headers or the user's account, you should remove the Dashboard's privileges to better maintain a "least privileged" approach. This will make it less likely that the Dashboard's `ServiceAccount` will be abused: |
| kubectl delete clusterrole tekton-dashboard-backend | ||
| kubectl delete clusterrole tekton-dashboard-dashboard | ||
| kubectl delete clusterrole tekton-dashboard-pipelines | ||
| kubectl delete clusterrole tekton-dashboard-tenant | ||
| kubectl delete clusterrole tekton-dashboard-triggers | ||
| kubectl delete clusterrolebinding tekton-dashboard-backend | ||
| kubectl delete rolebinding tekton-dashboard-pipelines -n tekton-pipelines | ||
| kubectl delete rolebinding tekton-dashboard-dashboard -n tekton-pipelines | ||
| kubectl delete rolebinding tekton-dashboard-triggers -n tekton-pipelines | ||
| kubectl delete clusterrolebinding tekton-dashboard-tenant |
There was a problem hiding this comment.
Maybe we should consider adding a label to these resources to more easily target them for deletion and avoid having to keep this list up to date. What do you think? e.g. rbac.dashboard.tekton.dev/default: true or similar so we could kubectl delete clusterrole -l rbac.dashboard.tekton.dev/default=true etc.
Technically only the bindings need to be deleted, so maybe rbac.dashboard.tekton.dev/subject: tekton-dashboard or similar would be more suitable on those, to make it clear we're removing the default permissions granted the Dashboard's SA.
I think we'll likely add an additional manifest (or at least an installer script flag) in future to install the Dashboard without these resources. This would probably make sense as part of the remaining work to improve the experience with custom RBAC, impersonation, etc.
tekton-robot
added
ok-to-test
Changes
Updated docs with RBAC for least privileged access when using a reverse proxy for authentication
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
See the contribution guide
for more details.