Drop lerna and switch to npm workspaces #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
do-not-merge/work-in-progress
|
Testing on Windows looks good 👍 |
AlanGreene
force-pushed
the
workspaces
branch
from
b3a303b
to
006dddb
Compare
Remove dependency on lerna and remove related npm scripts from the packages, tests, and build scripts. Since we no longer run a babel build on the packages we need to change how the package content is exposed (i.e. `src/` instead of `dist/`). Add each workspace explicitly to ensure commands are run in the correct order as npm doesn't currently run them in topological order (i.e. `components` depends on `utils` so we need to make sure `utils` is built first). Ensure the published components package references the corresponding utils package version (using `version` and `postpublish` scripts). This update resolves a number of npm audit warnings, as well as enabling hot reloading of code in the `packages/` folder that previous required manual steps to rebuild.
AlanGreene
force-pushed
the
workspaces
branch
from
006dddb
to
584c4f4
Compare
tekton-robot
removed
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Remove dependency on lerna and remove related npm scripts from the packages,
tests, and build scripts.
Since we no longer run a babel build on the packages we need to change how the
package content is exposed (i.e.
src/instead ofdist/).Add each workspace explicitly to ensure commands are run in the correct
order as npm doesn't currently run them in topological order (i.e.
componentsdepends onutilsso we need to make sureutilsis builtfirst).
Ensure the published components package references the corresponding
utils package version (using
versionandpostpublishscripts).This update resolves a number of npm audit warnings, as well as enabling
hot reloading of code in the
packages/folder that previous required manualsteps to rebuild.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
See the contribution guide
for more details.