Update components to support displaying new Cancelled status
#2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/M
AlanGreene
requested review from
briangleeson
and removed request for
skaegi and
steveodonovan
briangleeson
reviewed
Mar 1, 2022
TEP-0058 Graceful Termination deprecated the existing `PipelineRunCancelled` status. Instead, runs have the status reason `Cancelled`. The feature is still in alpha, so to test it out you can edit the `feature-flags` ConfigMap to set `enable-api-fields: alpha`, then use one of the following values when cancelling the PipelineRun: - `Cancelled` replaces the existing `PipelineRunCancelled`, interrupts any executing tasks and does not run finally tasks - `StoppedRunFinally` lets any executing tasks complete normally but does not start any new non-finally tasks, then runs finally tasks - `CancelledRunFinally` interrupts any executing non-finally tasks, then executes finally tasks In all 3 cases above, the PipelineRun status reason is `Cancelled` Update tests and storybook to include 'Cancelled' variants. The Dashboard API will still use `PipelineRunCancelled` to stop a PipelineRun. A future change once the feature has been promoted to beta will switch to the replacement `Cancelled` value. Some UI change may also be made to support the alternative behaviours, tracking this in tektoncd#2094
AlanGreene
force-pushed
the
graceful_termination_display
branch
from
b25b4b7
to
7ad4646
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
TEP-0058 Graceful Termination deprecated the existing
PipelineRunCancelledstatus. Instead, runs have the status reason
Cancelled.The feature is still in alpha, so to test it out you can edit the
feature-flagsConfigMap to set
enable-api-fields: alpha, then use one of the following valueswhen cancelling the PipelineRun:
Cancelledreplaces the existingPipelineRunCancelled, interrupts anyexecuting tasks and does not run finally tasks
StoppedRunFinallylets any executing tasks complete normally but does notstart any new non-finally tasks, then runs finally tasks
CancelledRunFinallyinterrupts any executing non-finally tasks, then executesfinally tasks
In all 3 cases above, the PipelineRun status reason is
CancelledUpdate tests and storybook to include 'Cancelled' variants.
The Dashboard API will still use
PipelineRunCancelledto stop a PipelineRun.A future change once the feature has been promoted to beta will switch to the
replacement
Cancelledvalue. Some UI change may also be made to support thealternative behaviours, tracking this in #2094
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
See the contribution guide
for more details.