Extract graph components and utils to separate package #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upcoming changes to the pipeline graph components will be introducing new dependencies such as Carbon Charts which I'd like to keep separate from the rest of the application for now. Extracting the graph components to their own package makes this easier and allows consumers to opt-in to the heavier dependencies as needed. This change is mostly a move/rename with no functional impact. Also clean up some unwanted entries in the package-lock that were causing an unnecessary `node_modules/` to be created in the components package.
tekton-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Upcoming changes to the pipeline graph components will be introducing
new dependencies such as Carbon Charts which I'd like to keep
separate from the rest of the application for now. Extracting the
graph components to their own package makes this easier and
allows consumers to opt-in to the heavier dependencies as needed.
This change is mostly a move/rename with no functional impact.
Also clean up some unwanted entries in the package-lock that were
causing an unnecessary
node_modules/to be created in the componentspackage.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
See the contribution guide
for more details.