Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deployment label #26

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Add deployment label #26

merged 1 commit into from
Apr 11, 2019

Conversation

jessm12
Copy link
Member

@jessm12 jessm12 commented Apr 11, 2019

Add app label app=tekton-dashboard-deployment for issue #25 and rename deployment

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 11, 2019
@tekton-robot
Copy link
Contributor

Hi @jessm12. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 11, 2019
@a-roberts a-roberts self-requested a review April 11, 2019 11:23
@a-roberts
Copy link
Member

Yeah, this gives us pod names of the format tekton-dashboard-xxxxx and the deployment indeed has the label, looks good to me!

/approve

@a-roberts a-roberts mentioned this pull request Apr 11, 2019
Closed
@mnuttall
Copy link
Contributor

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-roberts, jessm12, mnuttall

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2019
@mnuttall mnuttall merged commit 71294cf into tektoncd:master Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-roberts a-roberts Awaiting requested review from a-roberts

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jessm12 @tekton-robot @a-roberts @mnuttall