Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Triggers resources to v1beta1 #2614

Merged
merged 1 commit into from Nov 30, 2022

Conversation

AlanGreene
Copy link
Member

Changes

Update API calls for the following resources to use v1beta1 instead of v1alpha1:

  • ClusterTriggerBinding
  • EventListener
  • Trigger
  • TriggerBinding
  • TriggerTemplate

v1beta1 has been supported since Triggers v0.15.0, and our current minimum supported version is v0.21.0.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Request v1beta1 version for supported Triggers resources, this includes: `ClusterTriggerBinding`, `EventListener`, `Trigger`, `TriggerBinding`, and `TriggerTemplate`

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 30, 2022
@AlanGreene AlanGreene requested review from briangleeson and removed request for skaegi November 30, 2022 11:29
Update API calls for the following resources to use `v1beta1` instead
of `v1alpha1`:
- `ClusterTriggerBinding`
- `EventListener`
- `Trigger`
- `TriggerBinding`
- `TriggerTemplate`

`v1beta1` has been supported since Triggers v0.15.0, and our current
minimum supported version is v0.21.0.
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 30, 2022
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 30, 2022
@tekton-robot tekton-robot merged commit 3e0603a into tektoncd:main Nov 30, 2022
@AlanGreene AlanGreene deleted the triggers_beta branch November 30, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants