Update import resources to specify version v1beta1 #2651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stick with v1beta1 API version for the import resources API call (create PipelineRun) as we currently rely on PipelineResources which are no longer available in v1. We'll be switching to using the resolvers included since Tekton Pipelines v0.40 instead, but pin the version for now to prevent issues when users enable the v1 toggle on the settings page.
tekton-robot
added
kind/misc
briangleeson
reviewed
Jan 5, 2023
|
It's the same as the previous change for ClusterTasks and other resources that don't yet provide v1 support, and I expect it'll be gone in a week or two anyway once we switch to using resolvers to pull in the git-clone tasks instead of using the git PipelineResource. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Follow-up to #2649
Stick with v1beta1 API version for the import resources API call (create PipelineRun) as we currently rely on PipelineResources which are no longer available in v1.
We'll be switching to using the resolvers included since Tekton Pipelines v0.40 instead, but pin the version for now to prevent issues when users enable the v1 toggle on the settings page.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes