Switch default install mode to read-only #2661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
kind/misc
|
/hold |
tekton-robot
added
the
do-not-merge/hold
|
/test tekton-dashboard-unit-tests |
AlanGreene
force-pushed
the
readonly
branch
2 times, most recently
from
495453a
to
e4d4581
Compare
tekton-robot
added
lgtm
Update release pipeline to rename release manifests for consistency with other Tekton projects. The default release is provided by `release.yaml` which installs the Dashboard in read-only mode. `release-full.yaml` provides the read/write version. Update the installer script to switch the default behaviour to install the Dashboard in read-only mode. Replace the `--read-only` flag with `--read-write` to override the default behaviour and produce the read/write manifests. Update tests and documentation to reflect the new defaults.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 tasks
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update release pipeline to rename release manifests for consistency with other Tekton projects. The default release is provided by
release.yamlwhich installs the Dashboard in read-only mode.release-full.yamlprovides the read/write version.Update the installer script to switch the default behaviour to install the Dashboard in read-only mode. Replace the
--read-onlyflag with--read-writeto override the default behaviour and produce the read/write manifests.Update tests and documentation to reflect the new defaults.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes