Update error handling for application loading state #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the request for the messages bundle is blocked at the network level (not a 404 or other 'normal' error, request rejected / dropped somewhere before response reaches client), this causes the main app component to fall over. This was discovered in the nightly tests for the Z (s390x) platform running on dogfooding. Update the processing of the messages bundle to handle this more gracefully and fallback to the default locale. Move the display of the error notification inside the `Content` component so that it's fully visible on screen.
tekton-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
If the request for the messages bundle is blocked at the network level (not a 404 or other 'normal' error, request rejected / dropped somewhere before response reaches client), this causes the main app component to fall over. This was discovered in the nightly tests for the Z (s390x) platform running on dogfooding.
Update the processing of the messages bundle to handle this more gracefully and fallback to the default locale.
Move the display of the error notification inside the
Contentcomponent so that it's fully visible on screen.Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes