Update eslint plugins #2688
Merged
Update eslint plugins #2688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable `import/no-cylce` as it prevents us from using 'index' files
for clean imports internally in the application, i.e.
`import { A, B, C, … } from '..';`
becomes
```
import A from '../A';
import B from '../B';
import C from '../C';
…
```
This is a pattern we use extensively throughout the code, both in the
components package, and in the Dashboard application containers to
provider cleaner and more readable imports.
webpack and babel already handle potential cycles gracefully by stubbing
with an empty module, and these are tree-shaken during build as there
are no actual cycles used.
tekton-robot
added
kind/misc
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
#2686
Disable
import/no-cylceas it prevents us from using 'index' files for clean imports internally in the application, i.e.import { A, B, C, … } from '..';becomes
This is a pattern we use extensively throughout the code, both in the components package, and in the Dashboard application containers to provider cleaner and more readable imports.
webpack and babel already handle potential cycles gracefully by stubbing with an empty module, and these are tree-shaken during build as there are no actual cycles used.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes