Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DEVELOPMENT.md #27

Merged
merged 6 commits into from
Apr 12, 2019
Merged

Add DEVELOPMENT.md #27

merged 6 commits into from
Apr 12, 2019

Conversation

a-roberts
Copy link
Member

@a-roberts a-roberts commented Apr 11, 2019

For #23, review comments, testing and feedback welcome, it references using Dockerfile_test which is at PR #21 and should be merged first.

@jessm12 @dibbles please take a look 馃懠.

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 11, 2019
DEVELOPMENT.md Outdated Show resolved Hide resolved
DEVELOPMENT.md Show resolved Hide resolved
DEVELOPMENT.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2019
@a-roberts
Copy link
Member Author

Think I've addressed all of the comments now, @dibbles can you please take a look again and @skaegi if you're happy too let's get this merged or further worked on?

Feedback welcome, perhaps we want to mention more about the frontend now? I'm a backend coder rn so likely missed loads - what else should we be adding? Thanks

DEVELOPMENT.md Show resolved Hide resolved
DEVELOPMENT.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@AlanGreene
Copy link
Member

/lgtm

@tekton-robot
Copy link
Contributor

@AlanGreene: changing LGTM is restricted to assignees, and only tektoncd/dashboard repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@jessm12 jessm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor change comments from me 馃檪

DEVELOPMENT.md Outdated Show resolved Hide resolved
DEVELOPMENT.md Outdated Show resolved Hide resolved
DEVELOPMENT.md Outdated Show resolved Hide resolved
DEVELOPMENT.md Outdated Show resolved Hide resolved
@jessm12
Copy link
Member

jessm12 commented Apr 12, 2019

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-roberts, jessm12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@a-roberts a-roberts merged commit c0043b7 into tektoncd:master Apr 12, 2019
@a-roberts a-roberts deleted the developmentdocs branch April 12, 2019 13:24
@bobcatfish
Copy link
Contributor

馃樆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants