-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DEVELOPMENT.md #27
Conversation
Think I've addressed all of the comments now, @dibbles can you please take a look again and @skaegi if you're happy too let's get this merged or further worked on? Feedback welcome, perhaps we want to mention more about the frontend now? I'm a backend coder rn so likely missed loads - what else should we be adding? Thanks |
/lgtm |
@AlanGreene: changing LGTM is restricted to assignees, and only tektoncd/dashboard repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few minor change comments from me 馃檪
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-roberts, jessm12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
馃樆 |
For #23, review comments, testing and feedback welcome, it references using Dockerfile_test which is at PR #21 and should be merged first.
@jessm12 @dibbles please take a look 馃懠.