Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Create and Edit and run features for CustomRuns #3108

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

jisoolee
Copy link
Contributor

@jisoolee jisoolee commented Sep 5, 2023

Changes

The adding Create and Edit and run features for CustomRuns task and it is subdivided into 3 parts (will have 3 different commits per each part in one PR)

  • Part1. Adding Create and Edit and run buttons
  • Part2. Creating a Create page + Connecting the buttons to the proper Create/EditAndRun pages
  • Part3. Adding test cases

Part1. Adding Create and Edit and run buttons

b1
b2
b3

Part2. Creating a Create page + Connecting the buttons to the proper Create/EditAndRun pages

createcr

editandruncr

Part3. Adding test cases

image

Connect to #2437

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 5, 2023
@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 5, 2023
@tekton-robot
Copy link
Contributor

Hi @jisoolee. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlanGreene
Copy link
Member

Thanks @jisoolee. We need to make sure the Dashboard is always in a releasable state, so we'll either need to hide the buttons behind some kind of feature flag (query param or localStorage), or hold this PR until the create / edit page is merged first.

@jisoolee
Copy link
Contributor Author

jisoolee commented Sep 6, 2023

@AlanGreene Thank you for review and comment. I understand, yes I was also worrying about the release schedule (if I could not completed all the tasks before the next release). Please hold this PR until I complete the feature.

@AlanGreene
Copy link
Member

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2023
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2023
@jisoolee jisoolee changed the title Add Create button and Edit and run buttons for CustomRuns Add Create and Edit and run features for CustomRuns Sep 19, 2023
@AlanGreene AlanGreene removed the request for review from skaegi September 20, 2023 08:40
Copy link
Member

@AlanGreene AlanGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of code in this related to the form-based UI which we are not adding for CustomRuns. Once that's removed there may be some opportunities to simplify / cleanup the remaining code.

src/containers/CustomRuns/CustomRuns.jsx Outdated Show resolved Hide resolved
src/containers/CustomRuns/CustomRuns.jsx Outdated Show resolved Hide resolved
src/containers/CustomRuns/CustomRuns.jsx Outdated Show resolved Hide resolved
src/containers/CreateCustomRun/CreateCustomRun.jsx Outdated Show resolved Hide resolved
src/containers/CreateCustomRun/CreateCustomRun.jsx Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 20, 2023
src/containers/CustomRuns/CustomRuns.jsx Outdated Show resolved Hide resolved
src/containers/CustomRuns/CustomRuns.jsx Outdated Show resolved Hide resolved
src/containers/CustomRuns/CustomRuns.jsx Outdated Show resolved Hide resolved
src/api/customRuns.js Outdated Show resolved Hide resolved
src/api/customRuns.js Outdated Show resolved Hide resolved
src/api/customRuns.js Outdated Show resolved Hide resolved
src/containers/CreateCustomRun/CreateCustomRun.jsx Outdated Show resolved Hide resolved
src/containers/CreateCustomRun/CreateCustomRun.jsx Outdated Show resolved Hide resolved
src/containers/CreateCustomRun/CreateCustomRun.jsx Outdated Show resolved Hide resolved
src/containers/CreateCustomRun/CreateCustomRun.jsx Outdated Show resolved Hide resolved
@jisoolee jisoolee force-pushed the updatecustomruns branch 4 times, most recently from 7b8003e to a1bdc6c Compare September 29, 2023 13:27
Copy link
Member

@AlanGreene AlanGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still quite a bit of unused code here that needs to be removed. I've added comments to the biggest pieces.

Most of this should have been caught by the linter so I'll have to debug that to figure out why it's not reporting errors.

For now you'll have to manually review each function, variable, and state field you've added to ensure they're actually used, and remove any that are not needed. When you remove a function, for example handleSubmit, check if there are additional functions or variables that can be cleaned up following its removal.

src/api/customRuns.js Outdated Show resolved Hide resolved
src/containers/CreateCustomRun/CreateCustomRun.jsx Outdated Show resolved Hide resolved
src/containers/CreateCustomRun/CreateCustomRun.jsx Outdated Show resolved Hide resolved
src/containers/CreateCustomRun/CreateCustomRun.jsx Outdated Show resolved Hide resolved
src/containers/CreateCustomRun/CreateCustomRun.jsx Outdated Show resolved Hide resolved
src/containers/CreateCustomRun/CreateCustomRun.jsx Outdated Show resolved Hide resolved
src/containers/CreateCustomRun/CreateCustomRun.jsx Outdated Show resolved Hide resolved
src/containers/CreateCustomRun/CreateCustomRun.jsx Outdated Show resolved Hide resolved
src/containers/CreateCustomRun/CreateCustomRun.test.jsx Outdated Show resolved Hide resolved
src/containers/CustomRuns/CustomRuns.jsx Outdated Show resolved Hide resolved
@AlanGreene
Copy link
Member

For tracking purposes:

The issue with the linter not reporting issues was identified and resolved in #3139

@jisoolee jisoolee force-pushed the updatecustomruns branch 2 times, most recently from 3336cb9 to 48d0131 Compare September 29, 2023 19:11
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 29, 2023
@jisoolee jisoolee force-pushed the updatecustomruns branch 4 times, most recently from e823128 to 3f224c6 Compare October 3, 2023 15:40
src/api/customRuns.js Outdated Show resolved Hide resolved
src/containers/CreateCustomRun/CreateCustomRun.test.jsx Outdated Show resolved Hide resolved
src/containers/CreateCustomRun/CreateCustomRun.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2023
@briangleeson
Copy link
Contributor

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2023
@briangleeson
Copy link
Contributor

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 5, 2023
@tekton-robot tekton-robot merged commit 120ff7b into tektoncd:main Oct 5, 2023
8 checks passed
@AlanGreene AlanGreene mentioned this pull request Oct 17, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants