Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restful routes #48

Merged
merged 12 commits into from
Apr 16, 2019
Merged

Restful routes #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7807e3d
Ensure 201 success, credential test clean up
Apr 12, 2019
73b8971
Seperated methods for send and receive
Apr 12, 2019
0b2fa32
Location set properly
Apr 12, 2019
01d9c1e
Cleanup
Apr 12, 2019
5e0e881
Merge
Apr 12, 2019
3f4ecea
Request struct has route with paramtere injected, use instead of cons…
Apr 15, 2019
0d5031c
Merge branch 'master' of github.com:tektoncd/dashboard into restfulRo…
Apr 15, 2019
04af54c
Merge branch 'master' of github.com:tektoncd/dashboard into restfulRo…
Apr 15, 2019
8c3d8d1
PUT route fix, cleanup and modify development.md for changes
Apr 15, 2019
f8f69a5
All routes specify name, update credential as such (even secrets use …
Apr 15, 2019
ba8c6b1
Fix tests
Apr 15, 2019
eae287a
POST only
Apr 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions DEVELOPMENT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ POST /v1/namespaces/<namespace>/credentials
Create a new credential
Request body must contain id, username, password, type ('accesstoken' or 'userpass'), description and the URL that the credential will be used for (e.g. the Git server)

Returns HTTP code 200 if the credential was created OK
Returns HTTP code 201 if the credential was created OK and sets the 'Content-Location' header
Returns HTTP code 400 if a bad request was provided
Returns HTTP code 406 if no body is provided
Returns HTTP code 500 if an error occurred creating the credential
Expand All @@ -294,7 +294,7 @@ __Credentials__
PUT /v1/namespaces/<namespace>/credentials/<id>
Update credential by ID
Request body must contain id, username, password, type ('accesstoken' or 'userpass'), description and the URL that the credential will be used for (e.g. the Git server)
Returns HTTP code 200 and nothing else if the credential was updated OK
Returns HTTP code 204 if the credential was updated OK (no contents are provided in the response)
Returns HTTP code 400 if a bad request was provided or if an error occurs updating the credential
```

Expand Down