Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support custom secret in tekton results #1547

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

jkandasa
Copy link
Member

@jkandasa jkandasa commented Jun 6, 2023

Changes

For now there is no way to supply S3 credentials into results api pod via secrets. This PR optionally injects those references via environment variable into tekton-results-api deployment.
As these values are injected as environment variable takes the higher precedence.

There is an issue in results repository about this: tektoncd/results#469, tektoncd/results#432

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

To get `S3` credentials from secret, a new property called `secret_name` added under TektonResult spec. User can create a secret with `S3` credentials and update the secret name in `secret_name` property.

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 6, 2023
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 6, 2023
@jkandasa
Copy link
Member Author

jkandasa commented Jun 6, 2023

/cc @khrm

@tekton-robot
Copy link
Contributor

@jkandasa: GitHub didn't allow me to request PR reviews from the following users: khrm.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @khrm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/kubernetes/tektonresult/transform.go 66.7% 69.1% 2.4

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2023
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/kubernetes/tektonresult/transform.go 66.7% 69.1% 2.4

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/kubernetes/tektonresult/transform.go 66.7% 69.1% 2.4

@jkandasa jkandasa force-pushed the update_results_secret branch 2 times, most recently from d943664 to e0cdece Compare June 8, 2023 06:10
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/kubernetes/tektonresult/transform.go 66.7% 70.9% 4.3

@jkandasa
Copy link
Member Author

@piyush-garg
Copy link
Contributor

piyush-garg commented Jul 11, 2023

Issue on results tektoncd/results#432

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2023
Signed-off-by: Jeeva Kandasamy <jkandasa@redhat.com>
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2023
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/kubernetes/tektonresult/transform.go 66.7% 70.9% 4.3

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2023
@tekton-robot tekton-robot merged commit 6fb0477 into tektoncd:main Jul 12, 2023
7 of 8 checks passed
@jkandasa jkandasa deleted the update_results_secret branch July 12, 2023 10:51
@jkandasa jkandasa mentioned this pull request Sep 4, 2023
4 tasks
khrm added a commit to khrm/operator that referenced this pull request Sep 26, 2023
These fields come are configured via secrets e.g. tektoncd#1547
khrm added a commit to khrm/operator that referenced this pull request Sep 26, 2023
These fields come are configured via secrets e.g. tektoncd#1547
tekton-robot pushed a commit that referenced this pull request Sep 27, 2023
These fields come are configured via secrets e.g. #1547
tekton-robot pushed a commit to tekton-robot/operator that referenced this pull request Sep 27, 2023
These fields come are configured via secrets e.g. tektoncd#1547
tekton-robot pushed a commit that referenced this pull request Sep 27, 2023
These fields come are configured via secrets e.g. #1547
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants