-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support custom secret in tekton results #1547
Conversation
/cc @khrm |
@jkandasa: GitHub didn't allow me to request PR reviews from the following users: khrm. Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The following is the coverage report on the affected files.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2848ec
to
bd688e0
Compare
The following is the coverage report on the affected files.
|
bd688e0
to
9df86c9
Compare
The following is the coverage report on the affected files.
|
d943664
to
e0cdece
Compare
The following is the coverage report on the affected files.
|
Issue on results tektoncd/results#432 |
/lgtm |
Signed-off-by: Jeeva Kandasamy <jkandasa@redhat.com>
e0cdece
to
2b8d4b4
Compare
The following is the coverage report on the affected files.
|
/lgtm |
These fields come are configured via secrets e.g. tektoncd#1547
These fields come are configured via secrets e.g. tektoncd#1547
These fields come are configured via secrets e.g. #1547
These fields come are configured via secrets e.g. tektoncd#1547
These fields come are configured via secrets e.g. #1547
Changes
For now there is no way to supply
S3
credentials into results api pod via secrets. This PR optionally injects those references via environment variable intotekton-results-api
deployment.As these values are injected as environment variable takes the higher precedence.
There is an issue in results repository about this: tektoncd/results#469, tektoncd/results#432
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lint
before submitting a PRSee the contribution guide for more details.
Release Notes