Update golangci configuration ☕

This removes some flags that are now in the configuration, and add
more information. Trying `disable-all` with `enable` to limit the
linter run to only the one we specify. Also trying to run less linters
on `_test.go`.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>

.golangci.yml

@@ -1,18 +1,31 @@
-run:
-  build-tags:
-  - e2e
-  skip-dirs:
-  - vendor
-  - pkg/client
-  timeout: 5m
 linters-settings:
   errcheck:
     exclude: .errcheck.txt
 linters:
+  disable-all: true
   enable:
   - errcheck
   - gofmt
   - goimports
   - gosec
   - gocritic
   - golint
+output:
+  uniq-by-line: false
+issues:
+  exclude-rules:
+  - path: _test\.go
+    linters:
+    - errcheck
+    - gosec
+  max-issues-per-linter: 0
+  max-same-issues: 0
+run:
+  issues-exit-code: 1
+  build-tags:
+  - e2e
+  skip-dirs:
+  - vendor
+  - pkg/client
+  timeout: 10m
+  modules-download-mode: vendor

test/presubmit-tests.sh

@@ -32,8 +32,7 @@ source $(git rev-parse --show-toplevel)/vendor/github.com/tektoncd/plumbing/scri
 function post_build_tests() {
   header "running golangci-lint"
   # deadline of 5m, and show all the issues
-  golangci-lint -j 1 --color=never \
-                run --modules-download-mode=vendor --max-issues-per-linter=0 --max-same-issues=0 --deadline 10m
+  golangci-lint -j 1 --color=never run
 }
 
 # We use the default build, unit and integration test runners.