Skip to content

Commit

Permalink
Use Webhook v1 APIs
Browse files Browse the repository at this point in the history
Use `admissionregistration.k8s.io/v1` instead of
`admissionregistration.k8s.io/v1beta1` for our admission
controllers (webhooks).

This change is mainly due to the fact that
`apiextensions.k8s.io/v1beta1` CRDs are deprecated and will be
unavailable at some point.

```
Warning: apiextensions.k8s.io/v1beta1 CustomResourceDefinition is
deprecated in v1.16+, unavailable in v1.22+; use
apiextensions.k8s.io/v1 CustomResourceDefinition
```

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
  • Loading branch information
vdemeester authored and tekton-robot committed Nov 2, 2020
1 parent dc07540 commit b72fc4f
Showing 1 changed file with 6 additions and 9 deletions.
15 changes: 6 additions & 9 deletions config/500-webhooks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ metadata:
# The data is populated at install time.

---
apiVersion: admissionregistration.k8s.io/v1beta1
apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
metadata:
name: validation.webhook.pipeline.tekton.dev
Expand All @@ -35,8 +35,7 @@ metadata:
app.kubernetes.io/part-of: tekton-pipelines
pipeline.tekton.dev/release: "devel"
webhooks:
- admissionReviewVersions:
- v1beta1
- admissionReviewVersions: ["v1beta1", "v1"]
clientConfig:
service:
name: tekton-pipelines-webhook
Expand All @@ -46,7 +45,7 @@ webhooks:
name: validation.webhook.pipeline.tekton.dev

---
apiVersion: admissionregistration.k8s.io/v1beta1
apiVersion: admissionregistration.k8s.io/v1
kind: MutatingWebhookConfiguration
metadata:
name: webhook.pipeline.tekton.dev
Expand All @@ -56,8 +55,7 @@ metadata:
app.kubernetes.io/part-of: tekton-pipelines
pipeline.tekton.dev/release: "devel"
webhooks:
- admissionReviewVersions:
- v1beta1
- admissionReviewVersions: ["v1beta1", "v1"]
clientConfig:
service:
name: tekton-pipelines-webhook
Expand All @@ -67,7 +65,7 @@ webhooks:
name: webhook.pipeline.tekton.dev

---
apiVersion: admissionregistration.k8s.io/v1beta1
apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
metadata:
name: config.webhook.pipeline.tekton.dev
Expand All @@ -77,8 +75,7 @@ metadata:
app.kubernetes.io/part-of: tekton-pipelines
pipeline.tekton.dev/release: "devel"
webhooks:
- admissionReviewVersions:
- v1beta1
- admissionReviewVersions: ["v1beta1", "v1"]
clientConfig:
service:
name: tekton-pipelines-webhook
Expand Down

0 comments on commit b72fc4f

Please sign in to comment.