No event for PipelineValidationFailed

[Letty5411]

Expected Behavior

When try to run a pipelinerun, it failed with the following condition:

status:
  completionTime: 2019-08-16T06:07:38Z
  conditions:
  - lastTransitionTime: 2019-08-16T06:07:38Z
    message: 'invalid input params: missing values for these params which have no
      default values: [TESTCASE]'
    reason: PipelineValidationFailed
    status: "False"
    type: Succeeded
  startTime: 2019-08-16T06:07:38Z

In this situation, I expect that there may be event about this failure.

Actual Behavior

No event in this situation.

Steps to Reproduce the Problem

Additional Info

[NikeNano]

I would be happy to help out with this one @dibyom. Can I start to work on it?

[vdemeester]

@NikeNano I think this is gonna be fixed by #2082 (cc @afrittoli )

[afrittoli]

@Letty5411 thanks for reporting this and @NikeNano thanks for contributing!
There is definitely an inconsistency in how we generate emit events today, I tried to capture the complete (!) matrix in #2329

So indeed I was going to address this as part of #2082 / #2039.

[NikeNano]

@Letty5411 thanks for reporting this and @NikeNano thanks for contributing!
There is definitely an inconsistency in how we generate emit events today, I tried to capture the complete (!) matrix in #2329

So indeed I was going to address this as part of #2082 / #2039.

Ok, cool. Then I see if I can find some other issues to look at :)

[bobcatfish]

@afrittoli are you tackling both k8s events and cloudevents in your work?

[afrittoli]

@afrittoli are you tackling both k8s events and cloudevents in your work?

Yes, I am - first PR fixes k8s events, second PR will add cloudevents

[vdemeester]

@afrittoli is this fixed ? 🙃

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[tekton-robot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

[vdemeester]

Is this still the case ? (cc @afrittoli)

[tekton-robot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

[tekton-robot]

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.