Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate use of an admission webhook to ease move to beta #1379

Closed
skaegi opened this issue Oct 3, 2019 · 5 comments
Closed

Investigate use of an admission webhook to ease move to beta #1379

skaegi opened this issue Oct 3, 2019 · 5 comments
Assignees
Labels
area/api Indicates an issue or PR that deals with the API. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@skaegi
Copy link
Contributor

skaegi commented Oct 3, 2019

When we go beta we're going to end up with a ton of pre-existing Tekton resources that use apiVersion: tekton.dev/v1alpha1 where-as our stored versions will now be using apiVersion: tekton.dev/v1beta1 or similar.

One practice to help ease migration is to use a MutatingAdmissionWebhook. We should investigate adding one along with a battery of unit tests to validate the handling of apiVersion changes and other simple mutations we want to support.

@vdemeester vdemeester added area/api Indicates an issue or PR that deals with the API. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 4, 2019
@vdemeester
Copy link
Member

@skaegi note that we already are using a MutatingAdmissionWebhook and we have a slight mechanisms to do conversion… but yeah we need to enhance that and have confidence on it (hence the battery of tests 😝)

@bobcatfish bobcatfish added this to the Pipelines 0.9 🐱 milestone Oct 4, 2019
@vdemeester
Copy link
Member

/assign

@vdemeester
Copy link
Member

Small update on this: as #1529 shows (if people are not completely dead 💀 after reading the PR 😹) that it is definitely possible (and not that hard, thanks to knative/pkg code 👼). It comes with a few "gotchas", but it is doable.

@bobcatfish @skaegi Should we close this issue (as we know what is the status) and focus on #1526 ?

@vdemeester
Copy link
Member

/close

@tekton-robot
Copy link
Collaborator

@vdemeester: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Indicates an issue or PR that deals with the API. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants