Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate ways to specify ServiceAccountName for tasks in a PipelineRun #2614

Closed
jlpettersson opened this issue May 12, 2020 · 4 comments · Fixed by #3028
Closed

Duplicate ways to specify ServiceAccountName for tasks in a PipelineRun #2614

jlpettersson opened this issue May 12, 2020 · 4 comments · Fixed by #3028
Assignees
@vdemeester
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone
Pipelines v0.16

Comments

@jlpettersson
Copy link
Member

jlpettersson commented May 12, 2020 •
edited
Loading

Expected Behavior

A consistent way to declare ServiceAccountNames for tasks in a PipelineRun

Actual Behavior

There is now two ways, almost identical to specify ServiceAccountName for tasks in a PipelineRun. It is a bit confusing. What happens if I specify both fields but with different values?

spec:

  # existing way
  serviceAccountNames:
    - taskName: build-task
      serviceAccountName: sa-for-build
   
  # newly introduced
  taskRunSpecs:
    - taskName: build-task
      taskServiceAccountName: sa-for-build

The latter alternative seem to have been merged yesterday with #2389
/kind bug
@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 12, 2020
@jlpettersson
Copy link
Member Author

jlpettersson commented May 12, 2020 •
edited
Loading

That syntax was actually requested: #2362

but then I think one of the fields should be deprecated and documentation updated. It is a bit confusing to have both in the documentation right now.

@vdemeester
Copy link
Member

Yes serviceAccoutNames need to be marked as deprecated indeed 😇

@vdemeester
Copy link
Member

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 13, 2020
@bobcatfish
Copy link
Collaborator

Thanks for catching this @jlpettersson !

@vdemeester vdemeester added this to the Pipelines v0.15 milestone Jul 24, 2020
@vdemeester vdemeester self-assigned this Jul 24, 2020
@vdemeester vdemeester mentioned this issue Jul 29, 2020
Merged
4 tasks
abayer added a commit to abayer/tektoncd-pipeline that referenced this issue Jun 15, 2022
@abayer
Remove deprecated PipelineRun.Spec.ServiceAccountNames field.
2a0ce9a 
Finishing up tektoncd#2614

We had multiple ways to specify the `serviceAccountName` for `PipelineTask`s - the original `PipelineRun.Spec.ServiceAccountNames`, and the more general `PipelineRun.Spec.TaskRunSpecs`, which also allows specifying a pod template, metadata, and container overrides for individual steps and sidecars. Therefore, we deprecated `ServiceAccountNames`, and are now removing it.

This has been scheduled for removal since May 2021.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
@abayer abayer mentioned this issue Jun 15, 2022
Merged
5 tasks
abayer added a commit to abayer/tektoncd-pipeline that referenced this issue Jun 16, 2022
@abayer
Remove deprecated PipelineRun.Spec.ServiceAccountNames field.
ce74709 
Finishing up tektoncd#2614

We had multiple ways to specify the `serviceAccountName` for `PipelineTask`s - the original `PipelineRun.Spec.ServiceAccountNames`, and the more general `PipelineRun.Spec.TaskRunSpecs`, which also allows specifying a pod template, metadata, and container overrides for individual steps and sidecars. Therefore, we deprecated `ServiceAccountNames`, and are now removing it.

This has been scheduled for removal since May 2021.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
tekton-robot pushed a commit that referenced this issue Jun 16, 2022
@abayer @tekton-robot
Remove deprecated PipelineRun.Spec.ServiceAccountNames field.
a47eb50 
Finishing up #2614

We had multiple ways to specify the `serviceAccountName` for `PipelineTask`s - the original `PipelineRun.Spec.ServiceAccountNames`, and the more general `PipelineRun.Spec.TaskRunSpecs`, which also allows specifying a pod template, metadata, and container overrides for individual steps and sidecars. Therefore, we deprecated `ServiceAccountNames`, and are now removing it.

This has been scheduled for removal since May 2021.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vdemeester vdemeester

Labels
kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
Pipelines v0.16
Development

Successfully merging a pull request may close this issue.

Deprecate PipelineRun.Spec.ServiceAccountNames 🦌 vdemeester/tektoncd-pipeline
4 participants
@vdemeester @bobcatfish @jlpettersson @tekton-robot