Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old version of tekton images with tag :latest in examples #2883

Closed
praveen4g0 opened this issue Jul 1, 2020 · 7 comments · Fixed by #2902
Closed

Replace old version of tekton images with tag :latest in examples #2883

praveen4g0 opened this issue Jul 1, 2020 · 7 comments · Fixed by #2902
Labels
area/testing Issues or PRs related to testing

Comments

@praveen4g0
Copy link

To maintain consistency, in all examples v1alpha1/v1beta1 which uses tekton images with specific versions should be replaced with tag latest

Example:

for same task git-clone, I guess it's better we remove dependency of tags in our examples

@vdemeester
Copy link
Member

/area testing

latest wouldn't exercise changes in the PR itself though, we need to dynamically get the PR's image reference before running the tests. ko should help us with that.

@tekton-robot tekton-robot added the area/testing Issues or PRs related to testing label Jul 1, 2020
@vdemeester
Copy link
Member

/assign @praveen4g0

@tekton-robot
Copy link
Collaborator

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Collaborator

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 15, 2020
@tekton-robot
Copy link
Collaborator

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vdemeester
Copy link
Member

/remove-lifecycle rotten
/remove-lifecycle stale
/reopen

@tekton-robot tekton-robot reopened this Aug 17, 2020
@tekton-robot
Copy link
Collaborator

@vdemeester: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/remove-lifecycle stale
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants