Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entrypoint remote image fetch fails for a non-default service account with no ImagePullSecrets #584

Closed
abayer opened this issue Mar 5, 2019 · 2 comments
Closed

Entrypoint remote image fetch fails for a non-default service account with no ImagePullSecrets #584

abayer opened this issue Mar 5, 2019 · 2 comments
Assignees
@abayer

Comments

@abayer
Copy link
Contributor

abayer commented Mar 5, 2019

Expected Behavior

Publicly accessible images should be usable when using a non-default service account, even if it has no ImagePullSecrets defined.

Actual Behavior

All attempts to fetch remote images to handle their entrypoints with a non-default service account without any ImagePullSecrets fail like:

Failed to fetch remote image SOME_IMAGE:
No ImagePullSecret for service account SA_NAME: <nil>'

Steps to Reproduce the Problem

  1. Create a Pipeline with a Task using a publicly accessible image.
  2. Create a PipelineRun with an explicit service account, without adding any ImagePullSecrets to the service account, using that Pipeline.
  3. Check the PipelineRun's status.

Additional Info
@abayer
Copy link
Contributor Author

abayer commented Mar 5, 2019

/assign abayer

@abayer
Copy link
Contributor Author

abayer commented Mar 5, 2019

I have a potential fix (assuming it passes @pivotal-nader-ziada's approval!) but am working on a reproduction case test before I open a PR.

abayer added a commit to abayer/tektoncd-pipeline that referenced this issue Mar 5, 2019
@abayer
ServiceAccount without ImagePullSecrets should not fail to fetch
2915bb8 
While `ImagePullSecret`s would still be needed for any private
registry, not having any on the specified service account shouldn't
cause a failure to even try to fetch the image.

Fixes tektoncd#584
@abayer abayer mentioned this issue Mar 5, 2019
Merged
3 tasks
abayer added a commit to abayer/tektoncd-pipeline that referenced this issue Mar 5, 2019
@abayer
ServiceAccount without ImagePullSecrets should not fail to fetch
b4243ea 
While `ImagePullSecret`s would still be needed for any private
registry, not having any on the specified service account shouldn't
cause a failure to even try to fetch the image.

Fixes tektoncd#584
abayer added a commit to abayer/tektoncd-pipeline that referenced this issue Mar 5, 2019
@abayer
ServiceAccount without ImagePullSecrets should not fail to fetch
db60cf7 
While `ImagePullSecret`s would still be needed for any private
registry, not having any on the specified service account shouldn't
cause a failure to even try to fetch the image.

Fixes tektoncd#584
knative-prow-robot pushed a commit that referenced this issue Mar 5, 2019
@abayer @knative-prow-robot
ServiceAccount without ImagePullSecrets should not fail to fetch
eee89b0 
While `ImagePullSecret`s would still be needed for any private
registry, not having any on the specified service account shouldn't
cause a failure to even try to fetch the image.

Fixes #584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abayer abayer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abayer